bdeggleston commented on code in PR #4892:
URL: https://github.com/apache/cassandra/pull/4892#discussion_r3446744394
##########
src/java/org/apache/cassandra/db/Keyspace.java:
##########
@@ -628,11 +628,11 @@ private Future<?> applyInternalTracked(Mutation mutation,
Promise<?> future)
throw new RuntimeException("Testing write failures");
boolean started;
- try (WriteContext ctx = trackedWriteHandler.beginWrite(mutation, true))
+ try (WriteContext ctx = trackedWriteHandler.beginWrite(mutation,
makeDurable))
{
started =
MutationTrackingService.instance().startWriting(mutation);
- if (started)
+ if (started || !makeDurable)
Review Comment:
that's a good point, I'd forgotten you can turn off log durability for
keyspaces. I think the answer is that MT doesn't work without the mutation
journal, so we need to make this path only reachable on replay and that we add
a check to schema changes to fail validation if durable writes are turned off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
