bdeggleston commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3562148346
##########
src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java:
##########
@@ -145,7 +154,7 @@ public void get() throws WriteTimeoutException,
WriteFailureException, RetryOnDi
throwTimeout();
int candidateReplicaCount = candidateReplicaCount();
- if (blockFor() + failures > candidateReplicaCount)
+ if (!plan.responses().isSuccessful())
Review Comment:
no, the call to signal() is gated on `isComplete()` returning true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
