bdeggleston commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3562152239
##########
src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java:
##########
@@ -345,14 +357,17 @@ public Dispatcher.RequestTime getRequestTime()
protected void signal()
{
+ if (condition.isSignalled())
+ return;
+
//The ideal CL should only count as a strike if the requested CL was
achieved.
//If the requested CL is not achieved it's fine for the ideal CL to
also not be achieved.
- if (idealCLDelegate != null && blockFor() + failures <=
candidateReplicaCount())
+ if (idealCLDelegate != null && plan.responses().isSuccessful())
Review Comment:
no, the call to signal() is gated on isComplete() returning true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
