bdeggleston commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3562286442


##########
src/java/org/apache/cassandra/service/paxos/PaxosCommit.java:
##########
@@ -272,6 +424,24 @@ static <T extends Consumer<Status>> T commit(Agreed 
commit, Participants partici
                      consistencyForConsensus, consistencyForCommit, 
allowHints, onDone);
     }
 
+    void setAugmentedCommitFuture(Future<Void> future)
+    {
+        if (future != null)
+        {
+            augmentedCommit = new AugmentedCommit<>(onDone);
+            future.addCallback((result, failure) -> {
+                if (failure != null)
+                {
+                    augmentedCommit.onMutationComplete(new Status(new 
Paxos.MaybeFailure(true, replicas.size(), required, accepts(responses), 
emptyMap())));
+                }
+                else
+                {
+                    augmentedCommit.onMutationComplete(success);

Review Comment:
   this is only ever called via `PaxosCommit#start`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to