kinow commented on pull request #1153: URL: https://github.com/apache/jena/pull/1153#issuecomment-1008599356
@afs most of the feedback addressed, with one question about the menu navigation. I separated in commits, so we can revert or modify any of the changes (or if you'd like to take a look at what was required to change each one; I find it easier than with the old Bootstrap JS code, although it does require some understanding of Vue/JS.) Oh, also found a nasty bug. I was using the array index as `:key` in Vue. Vue has the concept of `data` in a component. The `Menu` component will have a `data` section, which belongs to the component (you can pass variables as `props` that are accessible in `this.prop` or `this.data`, anyhoo). When you want to display multiple items, you do something like `<div v-for"item in someList" :key="item.id">`. But I used the array index, which is a bad practice. In the end, deleting datasets too quickly could accidentally delete the wrong dataset :disappointed_relieved: :open_mouth: But it's fixed, and I couldn't find any other instance of that. So one possible bug fixed. I thought it would take longer, but since I finished everything in one day, I might still have time this week to start writing some tests to prevent any other possible bugs (inherited from the old code, or introduced by yours truly :) Bruno -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
