kinow commented on pull request #1153:
URL: https://github.com/apache/jena/pull/1153#issuecomment-1009877857


   I honestly have no idea why I added an `if` to check for the SPARQL Query 
and return the name differently :roll_eyes: I also didn't iterate the endpoints 
and operations, instead accessing array indexes directly.
   
   Just changed that now to be truly dynamic. I only don't display the endpoint 
name when it starts with an underscore. Looks like it render the lists 
correctly?
   
   
![image](https://user-images.githubusercontent.com/304786/148933763-f34a8fba-a489-4a82-a92e-24c0777060d9.png)
   
   The changes are, on the left hand side, SPARQL Query now has three (or as 
many as returned) entries instead of only two as before. And on the right hand 
side, we display the endpoint name now as long as it doesn't start with an 
underscore.
   
   How does that look @afs?
   
   > My personal test is "what would I want to see if looking back a year from 
now".
   
   Yeah, good test! I left the commits for your feedback, but I will squash 
into a single commit once we are OK with the changes here.
   
   But I left a few commits where I'm fixing JS bugs or issues with 
dependencies. There's one where I added the link to the bug in a dependency. I 
use commits like this normally when troubleshooting another update, looking at 
blame/log/bisect/etc :+1: 
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to