kinow commented on pull request #1153: URL: https://github.com/apache/jena/pull/1153#issuecomment-1011561543
>I had to add a license line as the second line of the SVG file to keep RAT happy. Thanks! >In the build, there are some deprecation warnings such as: >[INFO] DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. We can ignore that warning for now, I had it in a previous project too. It's a library that's using a deprecated syntax for division. Sometimes JS moves really really fast. But sometimes you find issues that take a few months/years to be fixed, like this one (first saw it about 1 year ago?). >and also this: >I tried npx browserslist@latest --update-db but it failed: I have that at $work as well :smile: so far most devs ignore it, but I will try to fix it and see if the warning goes away. If I find a solution will send a PR or just share how that was solved :+1: Shouldn't cause any inconvenience to users. >but I did get a useable fuseki-server. >These can be fixed, or merely noted because they "just are", after merge. The final version is the important part. The most important thing to check is if the app works OK, and if there are no browser console errors. There are other things we can optimize, like tree-shaking, remove warnings, improve load time (loading resources asynchronously), etc. But we should be good for now IMO. :+1: there might be more warnings in the console, or in the browser console. I'll go through these over the next days when writing tests too :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
