hartig commented on PR #2501: URL: https://github.com/apache/jena/pull/2501#issuecomment-2210584618
@afs I have now copied [the manifest-driven tests from the SPARQL CDTs repo](https://github.com/awslabs/SPARQL-CDTs/tree/main/tests) into this PR and integrated them to run automatically as unit tests (see commit https://github.com/apache/jena/pull/2501/commits/25494354c61e2999747b297b99d86e8bfca1d5cd). Of course, that increases the number of files in the PR even more ;-) Additionally, related to the very last paragraph of [my previous comment](https://github.com/apache/jena/pull/2501#issuecomment-2185172583), I have changed the implementation such that the `SAMETERM` tests don't fail (see commit https://github.com/apache/jena/pull/2501/commits/9cb08f1f4529c170680d5235c35ac8bf442f498e). To this end, I had to add a new constructor to `LiteralLabel` and a corresponding create-function to `LiteralLabelFactory`. Please take a look and let me know whether you consider these changes appropriate. (I am still waiting for our legal folks to advise me on how to proceed with creating the Software Grant Agreement.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
