hartig commented on PR #2501: URL: https://github.com/apache/jena/pull/2501#issuecomment-2147837844
> [@afs] Could you please create an issue at https://github.com/apache/jena/issues for this. Done: #2518 > [@afs] While there are a lot of files, it looks to me like the majority are consequences of adding FOLD and UNFOLD as SPARQL extensions. Yes indeed, and then there are also several new files for the functions (cdt:get, cdt:size, etc) as well as for the new datatypes and literals itself (incl. the parser of their lexical forms). > [@afs] The acceptance gateway includes whether "mvn clean install" completes. [...] > I had to fix one thing the build: > jena-arq/src/main/java/org/apache/jena/riot/system/CDTAwareParserProfile.java > > which does not have the license header. The build runs the "RAT" - Release Audit Tool - catches this in the maven build. I have added the license header (commit https://github.com/apache/jena/pull/2501/commits/6de9f470bdf29708085f42452a8e6b01752190fa). With this change, `mvn clean install` completes on my laptop without problems. > [@afs] "This branch cannot be rebased due to conflicts" - the PR at the moment isn't in line with the jena project main branch. I have synced the main branch of my fork, did `git rebase master` in my feature branch, and going through the conflicts now -- commit by commit. I have been on it for two hours now. It seems there are conflicts for almost all of my commits. I will let you know when I am done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
