#493: Trac: add status 'please review'
-----------------------+-----------------
Reporter: jblayloc | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: *general* | Version:
Keywords: INSPIRE |
-----------------------+-----------------
The INSPIRE folks would like to more explicitly encourage peer code
review.
To support this, we'd like Trac to have an additional status, "Please
Review", available from "in work", "assigned" or "new", and parallel to
"in merge".
The idea is that most of the time, you'll finish something and mark it as
"Please Review", reassigning it to someone else if you know who you would
like to read your work. Or not reassigning it if you don't know who
should review it, but want *someone* to. You remain responsible for your
ticket, though. To keep "Please Review" without assignments from piling
up, you should go through after a while and just make them "in merge"
instead.
Also sometimes small patches, emergency items, or things you get reviewed
by just asking the person who sits across from you can go straight from
"in work" to "in merge."
Also naturally we don't want to force other Invenio users to use the
"Please Review" status if it doesn't fit into their work organization
scheme.
Combined with the above we should have a checklist of what to look for and
a template for communicating branch status efficiently, and also a
cultural shift which is two-fold:
1) if you're asked to review something, do it.
2) on an ongoing basis, if you've got some spare cycles, look for
something marked "please review" and assigned to "nobody" so that you can
help out.
I've discussed this with a bunch of the folks over here and everyone seems
to agree it's a good idea.
--
Ticket URL: <https://invenio-software.org/ticket/493>
Invenio <http://invenio-software.org>
