#493: Trac: add status 'please review'
------------------------+---------------------
Reporter: jblayloc | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: *general* | Version:
Resolution: | Keywords: INSPIRE
------------------------+---------------------
Changes (by jlavik):
* status: infoneeded_new => new
Comment:
I also support the idea of introducing extra measures to further encourage
code reviews.
In this case, perhaps it could simply require an addition to the normal
work-flow, indirectly represented in Trac. I mean, that anything with
status 'in_merge' is deemed ready to be looked at, by someone. If this
someone happens to be John Integrator, then he will remark and perhaps
even integrate it, otherwise others can voice their opinion as well. To
avoid situations where someone is reviewing something that gets merged at
the same time, the reviewer/merger can let everyone know by submitting a
comment before reviewing.
This may sound a lot like what you are saying, and it is, but most of the
time people are interested in getting their stuff into master as soon as
possible, so I suspect many would skip the 'review_me' step in favor of
the 'in_merge' for this reason. These steps are also quite similar in
practice.
--
Ticket URL: <http://invenio-software.org/ticket/493#comment:2>
Invenio <http://invenio-software.org>
