#493: Trac: add status 'please review'
------------------------+----------------------------
Reporter: jblayloc | Owner:
Type: defect | Status: infoneeded_new
Priority: major | Milestone:
Component: *general* | Version:
Resolution: | Keywords: INSPIRE
------------------------+----------------------------
Changes (by jlavik):
* status: new => infoneeded_new
Comment:
Well, yeah, in the sense that you label this piece of code open for public
eyes, but also allowing it to be integrated if integrator deems it ready.
Perhaps some wording changes are needed for the Trac status, as 'in_merge'
may then not cover it all, perhaps something like 'merge_review' would
work.
The idea is that rather then (or in addition to) introducing a new step
that solely consists of reviewing, we could extend the meaning of
'in_merge' to also include reviewing, as it is almost what happens now,
just not explicitly to anyone else then integrators.
However, as you mention a separate review step would also be useful in its
own, if you know that this code certainly is not up for merging just yet,
but I want x to look at it. Which seems to be what you meant all along.
To put it more clearly; I propose both things. i.e. having a separate
'review' status, and also implicitly include open reviewal in the
'in_merge' step. Does this make sense?
--
Ticket URL: <http://invenio-software.org/ticket/493#comment:5>
Invenio <http://invenio-software.org>
