On Wed, 07 Sep 2011, Henning Weiler wrote: > So it certainly is bibauthorid that wrongly call p_r_s() with Unicode > strings. Unfortunately, the documentation of p_r_s() does not > explicitly warn about this issue and does not specify parameter types > concerning the encoding of strings.
Yeah. It is a kind of silent general assumption in many Invenio modules that input/output strings to various API functions are UTF-8 binary strings, not Unicode strings. > Please let us know if we should change our callers of p_r_s(). It is not strictly speaking necessary, since I'll apply the patch modified in the `convert' style, as discussed. So we'll be good. However, it may be interesting if you check and switch your callers anyway one day, especially if you may happen to want to use lower-level APIs in the future, such as search_unit(), because lower-level APIs assume that arguments were already properly washed before. Best regards -- Tibor Simko
