On 2016-05-25 23:16, Chris Ballinger wrote:
> Not sure about the proper way to submit a pull request, but we have some
> proposed modifications to the existing module that I'd like some
> feedback on first.
> 
> 1. push_enabled is not persisted across server restarts (only reloads).
> This means that users won't receive pushes until they login again. Is
> there an easy way to accomplish this with the existing persistent
> storage API? I had trouble finding docs for the storage API.

Someone filed an issue for it here FWIW:
https://prosody.im/issues/issue/676

> 2. pushes are triggered for typing notifications (and possibly other
> extraneous stanzas as well). Would this be desired for some use cases
> and configurable (for instance to wake up the receiving client more
> quickly), or would it be better to just filter out all messages without
> a body?

and MattJ wrote:
> I don't see any typical use cases for no-body messages being pushed.

It's not that simple, what about OMEMO, or other non-body message with
some alternative payload? And this problem also applies to Carbons, MAM
and possibly other things.

-- 
Kim "Zash" Alvefur

-- 
You received this message because you are subscribed to the Google Groups 
"prosody-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prosody-dev+unsubscr...@googlegroups.com.
To post to this group, send email to prosody-dev@googlegroups.com.
Visit this group at https://groups.google.com/group/prosody-dev.
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to