(Personally, I prefer the GNU option format, so my vote is that if a patch that passes muster is provided, it should be used).
-dave On Jan 12, 3:11 pm, Dave Bailey <[email protected]> wrote: > It would lead to an inconsistency with all of the other compiler > options that adhere to the underscore convention: > > --decode_raw > --descriptor_set_out > --disallow_services > --include_imports > --proto_path > > I think either all or none of them should be changed. > > -dave > > On Jan 12, 2:48 pm, Kenton Varda <[email protected]> wrote: > > > Well, hackiness usually leads to deeper problems. For example, if there's > > two ways to write the flag, then it's harder to grep for usages of it, > > particularly if you aren't actually aware that there are multiple ways to > > write it. I'm still leaning against this. > > Anyone else have an opinion? > > > On Mon, Jan 12, 2009 at 1:52 PM, David Biesack <[email protected]>wrote: > > > > As a user, I'm less concerned with the internal hackiness level, more > > > so with the consistent > > > interface :-) The code is clean enough to support both, it appears. > > > I'd vote for it; > > > I can contribute some code if you like. > > > > On Jan 12, 2:08 pm, Kenton Varda <[email protected]> wrote: > > > > Hmm, you're probably right that the arguments should have used hyphens > > > > rather than underscores. That said, we certainly can't just change it > > > > without breaking people, and accepting both seems hacky. > > > > > On Mon, Jan 12, 2009 at 10:19 AM, David Biesack <[email protected] > > > >wrote: --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
