It looks very attractive. Any plans to include exceptions? (I like the use of 'auto' keyword. Had not seen it in code like this before.)
William ----- Original Message ----- > There is no proton group in reviewboard, so I'm forwarding this here > for > comment. > > Andrew > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6929/ > ----------------------------------------------------------- > > Review request for qpid, Gordon Sim, Cliff Jansen, and Rafael > Schloming. > > > Description > ------- > > As an experiment I've wrapped the pn_message_t and Pn_messenger_t > structs and operations in very lightweight c++ classes pn::Message > and pn::Messenger. > > To see how this looks I've also transcribed the python messenger > examples to these new C++ wrappers. > > If this is generally liked then I propose to wrap the rest of the > proton API similarly. > > Some possible controversial (and definitely revisable) decisions I > made here: > > * I don't like to prefix setters and getters with "set" and "get" so > I didn't > > * I put the wrappers in the supplied header files rather than in a > new header file. > > > Diffs > ----- > > /proton/trunk/examples/c++/client.cpp PRE-CREATION > /proton/trunk/examples/c++/recv.cpp PRE-CREATION > /proton/trunk/examples/c++/send.cpp PRE-CREATION > /proton/trunk/examples/c++/server.cpp PRE-CREATION > /proton/trunk/proton-c/include/proton/message.h 1381265 > /proton/trunk/proton-c/include/proton/messenger.h 1381265 > > Diff: https://reviews.apache.org/r/6929/diff/ > > > Testing > ------- > > Compiled and ran the transcribed c++ examples > > > Thanks, > > Andrew Stitcher > > > >
