Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/11#issuecomment-82366307
On Mon, 2015-03-16 at 12:31 -0700, Andrew Stitcher wrote:
> I think you new pn_data_size() possibly has the wrong side effects -
> it seems to lose the pn_data cursor position, so that merely querying
> the size will be hard to intermix with appending to the pn_data. It is
> true that this is not something the current code ever does does, but I
> think making the query function have side effects (except caching the
> size itself perhaps) is unexpected.
>
> â
> Reply to this email directly or view it on GitHub.
>
Fixed
commit 973bad033ba3a1b700ab80ab4edee209ab81f05a
Author: Alan Conway <acon...@redhat.com>
Commit: Alan Conway <acon...@redhat.com>
NO-JIRA: Restore data position when measuring size of encoded data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
