Github user gemmellr commented on a diff in the pull request:
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ ---
    @@ -57,9 +58,13 @@ public void pop()
    -    public EventImpl put(Event.Type type, Object context)
    +    public EventImpl put(EventType type, Object context)
    -        if (tail != null && tail.getType() == type &&
    +        if (type == null)
    +            throw new IllegalArgumentException("Type cannot be null");
    +        if (!type.isValid())
    +            throw new IllegalArgumentException("Cannot put events of type 
" + type);
    +        if (tail != null && tail.getEventType() == type &&
    --- End diff --
    Would an equals() check be more appropriate now that EventType isn't 
necessarily an Enum (though granted it is natural and we know it is for the 
core events)?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to