Github user bozzzzo commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36178995
  
    --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java 
---
    @@ -80,15 +83,46 @@
             SELECTABLE_WRITABLE,
             SELECTABLE_EXPIRED,
             SELECTABLE_ERROR,
    -        SELECTABLE_FINAL
    +        SELECTABLE_FINAL,
    +        
    +        /**
    +         * This value must never be used to generate an event, it's only 
used as
    +         * a guard when casting custom EventTypes to builtin {@link Type} 
via
    +         * {@link Event#getBuiltinType()}.
    +         */
    +        NOT_A_BUILTIN_TYPE;
    --- End diff --
    
    I'll go with something on the theme NON_CORE_EVENT?
    
    The getBuiltinType() is from a previous iteration of the patch and should 
have been renamed to getType()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to