Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36521660
  
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/engine/EventType.java ---
    @@ -0,0 +1,42 @@
    +/*
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + *
    + */
    +package org.apache.qpid.proton.engine;
    +
    +/**
    + * Entry point for external libraries to add event types. Event types 
should be
    + * <code>final static</code> fields. EventType instances are compared by
    + * reference.
    + * <p>
    + * Event types are best described by an <code>enum</code> that implements 
the
    + * {@link EventType} interface, see {@link Event.Type}.
    + * 
    + * @author bozzo
    --- End diff --
    
    Can you drop all the @author tags, we dont tend to use them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to