Github user bozzzzo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36182863
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/CollectorImpl.java ---
@@ -57,9 +58,13 @@ public void pop()
}
}
- public EventImpl put(Event.Type type, Object context)
+ public EventImpl put(EventType type, Object context)
{
- if (tail != null && tail.getType() == type &&
+ if (type == null)
+ throw new IllegalArgumentException("Type cannot be null");
+ if (!type.isValid())
+ throw new IllegalArgumentException("Cannot put events of type
" + type);
+ if (tail != null && tail.getEventType() == type &&
--- End diff --
Can you please qualify 'the wrong thing', I really want to understand this?
With this overall change, I'm only working around the `final` of the enum,
not around other aspects of it's semantics. This change brings us about on-par
with proton-c imho where EventType === int.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
