On Wed, 2015-10-14 at 10:31 -0400, Rafael Schloming wrote: > It wasn't actually an accidental commit. If I recall correctly I > ended up > using it more like a 0xDEADBEEF value. It makes it easy to > distinguish > between the failure mode of an actual hang (e.g. infinite loop or > blocking > call inside a handler) vs reaching a state where there are simply no > more > events to process. I guess you can think of it like a heartbeat in a > way. >
It seems like an odd default. Can we make it 0 in the code and set it non-0 in tests if that is needed? Randomly waking up a user app that hasn't asked for heartbeats every sort-of-3-seconds is a surprising behavior. > --Rafael > > On Tue, Oct 13, 2015 at 10:56 AM, Michael Goulish < > mgoul...@redhat.com> > wrote: > > > > > But it's obvious how this constant was chosen. > > > > With circular reasoning. > > > > <rimshot/> > > > > > > > > ----- Original Message ----- > > > On Mon, 2015-10-12 at 16:05 -0400, aconway wrote: > > > > ... > > > > +1, that looks like the right fix. 3141 is an odd choice of > > > > default, > > > > even for a mathematician. > > > > > > > > > > At this point, I'm desperately trying to find an appropriate pi > > > joke : > > > -) > > > > > > Andrew > > > > > > > >
