I'm actually interested in the pattern, not in the actual code.
On Nov 13, 11:49 am, "T.J. Crowder" <[EMAIL PROTECTED]> wrote:
> Tobie,
>
> That code looks a bit off -- like maybe at some point it used to have
> entities that something, somewhere rendered as characters? Even the
> raw version has this for the escapeHTMLWithReplace version:
>
> return this.replace(/&/g,'&').replace(/</g,'<').replace(/>/
> g,'>').replace(/"/g, '"');
>
> ...which I'm guessing is meant to be / used to be:
>
> return this.replace(/&/g,'&').replace(/</g,'<').replace(/>/
> g,'>').replace(/"/g, '"');
>
> Just checking I'm not missing something obvious.
>
> -- T.J.
>
> On Nov 12, 4:05 pm, Tobie Langel <[EMAIL PROTECTED]> wrote:
>
> > Thanks for the write-up T.J.
>
> > Before we go ahead and document the styles, I'd like to have a bit
> > more input (with relevant example code, please!) of how we should
> > handle feature testing.
>
> > Here's the originally proposed implementation for String#escapeHTML:
>
> >https://gist.github.com/5e0cefdc5e4783f16b95
>
> > Best,
>
> > Tobie
>
> > On Nov 12, 4:38 pm, "T.J. Crowder" <[EMAIL PROTECTED]> wrote:
>
> > > In LH ticket #433, Tobie says there are (new) style rules being used
> > > in the rewrite effort that new contributions should adhere to. I've
> > > said that it's hard to conform to a style guide that doesn't exist,
> > > and suggested that a (brief) document saying what the goals and
> > > rationales are, giving the specifics, references, etc., would make
> > > sense -- for new contributors and current ones alike. Tobie agreed
> > > and asked for volunteers.
>
> > > Thought I'd widen the audience: Is there anyone who knows the new
> > > rules and can write them up? Then we can link to them from the
> > > Contribute page so people know what's going on.
> > > --
> > > T.J. Crowder
> > > tj / crowder software / com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Prototype: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~----------~----~----~----~------~----~------~--~---
