On Tue, Apr 17, 2012 at 09:13:34PM -0700, Ben Pfaff wrote:
John Darrington <j...@darrington.wattle.id.au> writes:
> + g_return_val_if_fail (idx < 0 || dict_get_var_cnt (d->dict) <=
idx, NULL);
>
> Personally I prefer assertions to be written in their separate
components rather than ored
> together, like this:
>
> g_return_val_if_fail (idx < 0, NULL);
> g_return_val_if_fail (dict_get_var_cnt (d->dict) <= idx, NULL);
>
> That way, when the condition fails, it's easier to find out which part
of the condition is failing.
Fair enough. I made that change and pushed this commit.
This seems to be causing the GUI to crash.-- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
