John Darrington <j...@darrington.wattle.id.au> writes: > On Tue, Apr 17, 2012 at 09:13:34PM -0700, Ben Pfaff wrote: > John Darrington <j...@darrington.wattle.id.au> writes: > > > + g_return_val_if_fail (idx < 0 || dict_get_var_cnt (d->dict) <= > idx, NULL); > > > > Personally I prefer assertions to be written in their separate > components rather than ored > > together, like this: > > > > g_return_val_if_fail (idx < 0, NULL); > > g_return_val_if_fail (dict_get_var_cnt (d->dict) <= idx, NULL); > > > > That way, when the condition fails, it's easier to find out which part > of the condition is failing. > > Fair enough. I made that change and pushed this commit. > > This seems to be causing the GUI to crash.
Argh. I've reverted it for the moment, not having time tonight to fix it properly. Sorry about that. _______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
