Issue #12864 has been updated by Jeff Weiss.

+1!

We have a few of options:

1. We can use Facter 2.0 in the next PE windows release.
1. We can backport to Facter 1.6.x.
1. We live with it being broken in PE 2.5.

I can totally get behind either 1 or 2. I think 3 is appalling.
----------------------------------------
Bug #12864: Windows domain fact should use primary dns suffix first
https://projects.puppetlabs.com/issues/12864#change-63091

Author: Josh Cooper
Status: Closed
Priority: Normal
Assignee: Jeff Weiss
Category: windows
Target version: 2.0.0
Keywords: windows
Branch: https://github.com/puppetlabs/facter/pull/193
Affected Facter version: 


Currently, the domain fact on Windows looks for the domain of the first network 
adapter for which IPEnabled is true. But Windows also has a concept of a 
primary/global dns suffix. If the primary DNS suffix is set, but none of the 
connection-specific domains are set, then facter will report an empty domain 
(which also affects the fqdn).

According to <http://technet.microsoft.com/en-us/library/cc959322.aspx>

<pre>
By default, the primary DNS suffix of a computer that is running Windows 2000 
is set to the DNS name of the Active Directory domain to which the computer is 
joined.
</pre>

Facter should use the primary DNS suffix as the domain, if it is defined. 
Otherwise, fall back to what it does now. The value of the primary DNS suffix 
is stored in 
<pre>HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\Domain</pre>
 There may also be a WMI way to retrieve this.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to