Issue #12864 has been updated by Daniel Pittman.
Jeff Weiss wrote: > I'm gonna poke at this because I don't think we've arrived at a resolution. > > To summarize the discussion: > > - It's currently broken on Windows. No, it isn't *broken*, it is "not returning the expected value for some-but-not-all users on Windows". Which, also, is exactly the state of the fact on Unix - since it gets this wrong at least some of the time. (Especially on multi-homed hosts, or hosts that have odd configuration in hosts vs resolv.conf vs DNS.) > - We want fix in PE 2.5.x > - A few ways to do this > - Does fix go into FOSS 2.7.x via Facter 1.6.x? > - May require Windows clients to regenerate certs > - We should warn users about breaking change > I am going to send an email to puppet-users and pe-users asking this > question. I believe that the set of users that care about this issue will > want > puppet/facter to report the correct fqdn, even if it means they will need to > regenerate certs. Assuming the response is positive, I will work on > getting this into facter 1.6.x and the next PE 2.5.x release, along with > verbage in the readme to describe this breaking change. ...and please keep in mind the set of users who don't care about this because it works, today, exactly as they expect - so will be kind of surprised that we break their systems all of a sudden! ---------------------------------------- Bug #12864: Windows domain fact should use primary dns suffix first https://projects.puppetlabs.com/issues/12864#change-63145 Author: Josh Cooper Status: Closed Priority: Normal Assignee: Jeff Weiss Category: windows Target version: 2.0.0 Keywords: windows Branch: https://github.com/puppetlabs/facter/pull/193 Affected Facter version: Currently, the domain fact on Windows looks for the domain of the first network adapter for which IPEnabled is true. But Windows also has a concept of a primary/global dns suffix. If the primary DNS suffix is set, but none of the connection-specific domains are set, then facter will report an empty domain (which also affects the fqdn). According to <http://technet.microsoft.com/en-us/library/cc959322.aspx> <pre> By default, the primary DNS suffix of a computer that is running Windows 2000 is set to the DNS name of the Active Directory domain to which the computer is joined. </pre> Facter should use the primary DNS suffix as the domain, if it is defined. Otherwise, fall back to what it does now. The value of the primary DNS suffix is stored in <pre>HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\Domain</pre> There may also be a WMI way to retrieve this. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
