Hahaha disregard that, it also returns true for directories. On Mon, Oct 12, 2009 at 8:14 AM, Rein Henrichs <[email protected]> wrote: > I would like to see a test for this. Also, FileTest.executable? > returns false if the file does not exist, so there is no need to test > for FileTest.file? as well. > > On Mon, Oct 12, 2009 at 1:39 AM, Brice Figureau > <[email protected]> wrote: >> >> +1 for this patch on top of the previous one, >> >> Isn't there any spec tests for this method? >> If there aren't maybe it would be the good time to add some. >> >> On Mon, 2009-10-12 at 14:28 +0800, Ohad Levy wrote: >>> Should i sent out the whole patch again or this is enough: ? >> >> I'd say: squash both so that James can apply it as one patch. I don't >> think it is necessary to repost, since it's a trivial change. >> Also if you could add a little bit more context to the description, >> including in which commit/ticket the regression appeared and why, that >> would help track down issues later. >> >> James, Luke: that'd be great if we could have this for 0.25.1, because >> this is a performance regression (even though only Ohad noticed it, >> seems only his servers have a damn-"slow" 'which') especially for >> yum/rpm users. >> >> Thanks, >> -- >> Brice Figureau >> Follow the latest Puppet Community evolutions on www.planetpuppet.org! >> >> >> >> >> > > > > -- > Rein Henrichs > http://reductivelabs.com >
-- Rein Henrichs http://reductivelabs.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
