On Oct 12, 2009, at 10:52 AM, Paul Nasrat wrote: > > 2009/10/12 Brice Figureau <[email protected]>: >> >> +1 for this patch on top of the previous one, >> >> Isn't there any spec tests for this method? >> If there aren't maybe it would be the good time to add some. > >> >> James, Luke: that'd be great if we could have this for 0.25.1, >> because >> this is a performance regression (even though only Ohad noticed it, >> seems only his servers have a damn-"slow" 'which') especially for >> yum/rpm users. > > It's probably worth doing similar in facter as well, it's cleaner and > more portable to search the path.
And for the record, I believe the numbers involved were around 0.07s per resource (instead of averaging 0.00s), so "damn slow" here is a bit relative. I think the reasons Ohad caught it are 1) he's got a bunch of resources and 2) he pays close attention to how long things take and where the time goes. I expect others are being hit by this and just don't realize it. -- Never esteem anything as of advantage to you that will make you break your word or lose your self-respect. -- Marcus Aurelius Antoninus --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
