On 12/10/09 20:03, Luke Kanies wrote: > On Oct 12, 2009, at 10:52 AM, Paul Nasrat wrote: > >> 2009/10/12 Brice Figureau <[email protected]>: >>> +1 for this patch on top of the previous one, >>> >>> Isn't there any spec tests for this method? >>> If there aren't maybe it would be the good time to add some. >>> James, Luke: that'd be great if we could have this for 0.25.1, >>> because >>> this is a performance regression (even though only Ohad noticed it, >>> seems only his servers have a damn-"slow" 'which') especially for >>> yum/rpm users. >> It's probably worth doing similar in facter as well, it's cleaner and >> more portable to search the path. > > And for the record, I believe the numbers involved were around 0.07s > per resource (instead of averaging 0.00s), so "damn slow" here is a > bit relative.
When we bisected the issue at Puppet Camp, we saw that all the package installation went from 1s to 8s. That's damn slow to me :-) His bug reports reports even more slowdowns, but I think he changed his packages so that he installs much less packages (ie meta-packages). > I think the reasons Ohad caught it are 1) he's got a bunch of > resources and 2) he pays close attention to how long things take and > where the time goes. I expect others are being hit by this and just > don't realize it. Yes, most people won't care what happens on the client as long as it doesn't produce load on the master. Or maybe people don't look to client metrics. Or people have fast 'which' or don't use yum/rpm :-) -- Brice Figureau My Blog: http://www.masterzen.fr/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
