On Dec 4, 2009, at 8:48 AM, Brice Figureau wrote:

>> Yeah, I knew-but-didn't-think-about parser.rb until I'd done "rake
>> mail_patches".  What's the recommended way of pulling that out (is
>> there an "exclude from diff" setting somewhere, or...?)
>
> I don't use mail_patches. I git format-patch by hand, then review them
> in an editor in which I also strip parser.rb. Then I manually git
> send-email.
> This way I control what I do.


I've often wondered about that.

If that's the case, we should split the mail_patches rake task into at  
least two separate tasks - one for creating the patches and one for  
mailing them.  That way you could easily make them, edit/review, and  
then email them, while still using the rake tasks.

-- 
Life is too short for traffic. --Dan Bellack
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com

--

You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en.


Reply via email to