On Dec 4, 2009, at 9:44 AM, Markus Roberts wrote: >>>> Yeah, I knew-but-didn't-think-about parser.rb until I'd done "rake >>>> mail_patches". What's the recommended way of pulling that out (is >>>> there an "exclude from diff" setting somewhere, or...?) >>> >>> I don't use mail_patches. I git format-patch by hand, then review >>> them >>> in an editor in which I also strip parser.rb. Then I manually git >>> send-email. >>> This way I control what I do. >> >> >> I've often wondered about that. >> >> If that's the case, we should split the mail_patches rake task into >> at >> least two separate tasks - one for creating the patches and one for >> mailing them. That way you could easily make them, edit/review, and >> then email them, while still using the rake tasks. > > We could also have rake task give you the option of editing the > patches. It would be nice if there was an exclude option for git-diff > / format-patches, so we could just exclude parser.rb, but it doesn't > look like it. The closest I can see would be marking it as binary > (which, since git is a kernel hacker tool, seems to be conflated with > "generated").
Either way. It just seems pretty obvious that the current system isn't as ideal as we would like. -- Risk! Risk anything! Care no more for the opinions of others, for those voices. Do the hardest thing on earth for you. Act for yourself. Face the truth. -- Katherine Mansfield --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
