On Wed, 27 Oct 2010 14:51:52 -0400, Jeff McCune wrote: > > I've re-submitted this patch. I rebased against 2.6.x because there > was a slight bug in variable expansion and bash was returning "unbound > variable" errors. > > This updated patch fixes that issue. > > Nigel requested I try and provide a bit more detail regarding the > glaring warning I've included in the script. Unfortuantely, I just > don't have the bandwidth to debug exactly what I mean by "Strange > things happen" right now. > > Is there a way to get this functionality into ext/ without me taking > the time to properly diagnose exactly what's happening when puppet is > installed in site_lib? > > I could remove the warning, or rephase it to not be so unspecific and > nebulous. > > I know this isn't ideal, but it's the best I can do right now. > > -Jeff >
I'm perfectly happy with this going into ext/ as-is. I think any improvements to it would be great, but I'd rather have the thing now, with the vague warning "there are some sharp edges", rather than waiting for them all to be mapped out. +1 from me, FWIW. -- Jacob Helwig
signature.asc
Description: Digital signature
