Paul Berry wrote: > On Wed, Oct 27, 2010 at 1:15 PM, Nigel Kersten <[email protected] > <mailto:[email protected]>> wrote: > > > > On Wed, Oct 27, 2010 at 12:00 PM, Jacob Helwig <[email protected] > <mailto:[email protected]>> wrote: > > On Wed, 27 Oct 2010 14:51:52 -0400, Jeff McCune wrote: > > > > I've re-submitted this patch. I rebased against 2.6.x because > there > > was a slight bug in variable expansion and bash was returning > "unbound > > variable" errors. > > > > This updated patch fixes that issue. > > > > Nigel requested I try and provide a bit more detail regarding the > > glaring warning I've included in the script. Unfortuantely, I > just > > don't have the bandwidth to debug exactly what I mean by "Strange > > things happen" right now. > > > > Is there a way to get this functionality into ext/ without me > taking > > the time to properly diagnose exactly what's happening when > puppet is > > installed in site_lib? > > > > I could remove the warning, or rephase it to not be so > unspecific and nebulous. > > > > I know this isn't ideal, but it's the best I can do right now. > > > > -Jeff > > > > I'm perfectly happy with this going into ext/ as-is. I think any > improvements to it would be great, but I'd rather have the thing > now, > with the vague warning "there are some sharp edges", rather than > waiting > for them all to be mapped out. > > +1 from me, FWIW. > > > I should have been clearer. > > +1 from me. > > My comments were meant to be "this would be nice to have". > > > Available in next as commit:777d19ec48616bd29d66190c94ce6bdba00a5692 > > Still awaiting merge into 2.6.x. >
I haven't pushed 2.6.x yet. Just doing some testing this afternoon. James -- Puppet Labs - http://www.puppetlabs.com C: 503-734-8571 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
