On 14/12/10 19:32, Peter Meier wrote: > Hi Paul and Jesse, > >> Thanks for working on this long-standing feature request. Jesse Wolfe and I >> reviewed the code, and there are a few issues that would need to be >> addressed before we can merge the patches into the codebase. > > thanks for looking at my patch. It took me some time to revise your > comments, but I should be able to work tomorrow or at least this week on > the missing parts. > > In general I agree with them. But some questions remain, especially as > there is some limited knowledge of puppet internals from my side:
I'm usually available in #puppet-dev during European time (during the week) and might be able to actually answer you on specific questions :) Ping me if you need. >> [snip] >> - clean_cached_node() is calling the indirector in a clumsy way. It would >> be better to set the Node terminus to :yaml and then simply do >> Puppet::Node.destroy(). > > I'm still struggling a bit with the idea and the internals of the > indirector and googling "puppet indirector" didn't reveal the magic > hitchhiker's guide to puppet's indirector. Is there any? (I will scan > the -dev Archive after I sent that mail) > > So as far as I understood your proposal this would look like: > > # clean cached node +host+ > def clean_cached_node(host) > Puppet::Node.terminus = :yaml > Puppet::Node.destroy(Puppet::Node.indirection.request(:destroy, host)) > Puppet.info "%s's cached node removed" % host > end Can't you use the following? Puppet::Node.find(host).destroy > But well the part with the request looks still a bit clumsy and I > suspect that there is an easier way to do it? > > [snip] >> Regarding patch 5 (Finish implementation of #1886) >> >> - This should be combined with patch 1, since it fixes bugs in patch >> 1. > > > Yeah, in general I left Brice's patches as they were to give him still > the credits in the history for his initial work. But I think the mess is > too big and I will simply squash them all together. Or how should I do it? I hereby give you the permission to remove/edit/mangle my code if you need to :) It's great you're taking over, just don't feel like you need to keep my code around, I'm not caring that much :) >> - Our other apps use "-d" as short for "--debug" and "-v" as short for >> "--verbose". Puppet clean should support this too. > > As proposed by Brice, I have a patch that refactors --debug and > --verbose of all apps into Puppet::Application. It will be a separate > (initial) patch for the upcoming fixed patch series for #1886. Do you > think that this needs a separate ticket? That's good! [last part snipped] -- Brice Figureau My Blog: http://www.masterzen.fr/ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
