First: Sorry that it took me such a long time to integrate all your comments. This was mainly because I was busy with a lot of other things. However, the indirector is sometimes still a big magic part of the puppet framework for me. But, I think, that with the work for these changes I gain more insight and also understand many things now much better. :)
Anyway, so here are two patches which are the outcome of the rework I did to integrate all the comments and remarks Paul and Jessy gave, as well as the idea of Brice to integrate --debug and --verbose into Application. So the first patch refactors --debug and --verbose into Application and cleans up a lot of the duplicated code we had floating around as nearly every application was implementing these options. This should probably go into its own ticket. However, as the idea to refactor these options came up in the discussion for the changes for #1886 I thought it will be fine have that patch part of that series. If you think it might be better to open another ticket, I can do that. Then the second patch implements #1886. I hope, that I integrated all your comments, as well as improved some of the things I encountered during the usage of my code. So btw: it is tested in production and worked fine. :) I was completely aware the last time that this mix of patches from Brice and me is a big mess. As it for example included the move to Puppet::Application for 2.6. Therefore, I squashed now everything together into one (big) patch. So I hope it is now much more readable. Also, Brice gave me the permission to take over git-authorship for that piece of code. Anyway thanks for your review and if you think things could be improved I will be much faster that time. :) ~pete -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
