Two quick comments. * This should really be squashed in with the 1/2 patch, since the first one breaks the tests. (Ideally every commit in a patch series would have all of the tests passing.) This isn't a big deal, as we can squash these when pulling them in.
* The commit message for this patch doesn't line up with the implementation. Am I misreading one or the other? -- Jacob Helwig On Tue, 12 Apr 2011 11:52:33 +1000, Ben Hughes wrote: > > Fix the spec test for agent fingerprinting with stubbing of puts. > > This is because it no longer uses the Puppet.logging functionality, so we > need to stub Kernel as well. > > Signed-off-by: Ben Hughes <[email protected]> > --- > spec/unit/application/agent_spec.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/spec/unit/application/agent_spec.rb > b/spec/unit/application/agent_spec.rb > index 8f498d4..9cc32bb 100755 > --- a/spec/unit/application/agent_spec.rb > +++ b/spec/unit/application/agent_spec.rb > @@ -563,7 +563,7 @@ describe Puppet::Application::Agent do > @host.stubs(:certificate).returns(@cert) > @cert.stubs(:fingerprint).with(:MD5).returns("DIGEST") > > - Puppet.expects(:notice).with("DIGEST") > + @puppetd.expects(:puts).with "DIGEST" > > @puppetd.fingerprint > end > -- > 1.7.4.2 >
signature.asc
Description: Digital signature
