On Mon, 18 Apr 2011 11:20:07 +1000, Ben Hughes wrote:
> On Fri, Apr 15, 2011 at 09:25:58AM -0700, Jacob Helwig wrote:
> 
> > * The commit message for this patch doesn't line up with the
> >   implementation.  Am I misreading one or the other?
> 
> Perhaps. It now uses puts instead of Puppet.notice, so it's not using
> Puppet logging. The original test stubbed the Puppet logging.
> 

So, the disconnect I was referring to here was that the commit message
mentions "so we need to stub Kernel as well", but that's not actually
what's going on.  #puts is being stubbed on the @puppetd instance.

I could be nit-picking, but I wanted to make sure that I was just
nit-picking and that it wasn't indicitave of something larger going on.

-- 
Jacob Helwig

Attachment: signature.asc
Description: Digital signature

Reply via email to