On Fri, Apr 15, 2011 at 09:25:58AM -0700, Jacob Helwig wrote: > * This should really be squashed in with the 1/2 patch, since the first > one breaks the tests. (Ideally every commit in a patch series would > have all of the tests passing.) This isn't a big deal, as we can > squash these when pulling them in.
Ah okay. I was in two minds whether to squash it or not. > * The commit message for this patch doesn't line up with the > implementation. Am I misreading one or the other? Perhaps. It now uses puts instead of Puppet.notice, so it's not using Puppet logging. The original test stubbed the Puppet logging. -- Ben Hughes || http://www.puppetlabs.com/
pgpEwNzwzJflQ.pgp
Description: PGP signature
