Yeah, there is a problem with getting pull requests reviewed. And I think you are right, the problem stems from being short staffed for responding to these things. A pull request can take considerable amount of time to review and shepherd through (or it can take very little time if it is good, clean, tested code that is fixing an obvious problem). At the same time we are trying to concentrate on getting Telly ready, which distracts us from community pull requests.
The process we are currently using for deciding what to work on is that every Monday morning we have a planning session and grab things from our backlog of work (which includes pull requests, bugs in redmine, and feature work) pull out what will consume about a week of work for the team, which is currently 2 developers (Jeff McCune and Patrick Carlisle) and an intern (Hailee Kenney) for general tasks and another developer for improving our windows support (Josh Cooper) and me, who I count as less than half a developer. During the week we try to stick to what we planned on Monday so that we can focus and try to get things all the way done. Previously I had tried to get us to focus entirely on just working on what was needed for the Telly release and not dealing with pull requests, but since that is taking longer than expected we changed last week to start working on pull requests again. Our first approach was to take all of the PRs that had been submitted in the last 7 days and try to get through those and then to move on to working on the next release (although some were for getting Telly done). That ended with us not ever getting to working on the tasks for Telly. So what we learned last week is that we cannot stay on top of the pull requests at the moment (although some of this might be that we just need to tune how we deal with pull requests). This week we are going to change the process a bit. Instead of trying to get through the entire seven days of pull requests we will just be dedicating a single person to dealing with whatever is outstanding and the rest of the team will be working on the next release. I'm sorry that there have been so many problems with getting pull requests dealt with. It is something that is on our radar and we are trying to figure it out, but as you can see it isn't working yet. So keep poking us, don't let us forget about you! If you have any suggestions on how we could do this better, please, let me know. Andy Parker Puppet/Facter Team Lead On Jul 23, 2012, at 7:00 AM, Ashley Penney wrote: > Personally I find lurking on #puppet and bugging an appropriate person > to be about your best bet. Puppetlabs should hire a "Director of Pull > Requests" to manage all the queues for their various repos. :) > > On Mon, Jul 16, 2012 at 12:29 PM, Erik Dalén > <[email protected]> wrote: >> Hi, I have some pull requests against puppet that haven't been >> reviewed in quite some time and so does a lot of other people as well. >> Do you need to poke anyone to get a pull request reviewed? Or what's >> the process for that? >> >> -- >> Erik Dalén >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Puppet Developers" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/puppet-dev?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
