Although running the tests is important it isn't really the slowest part of the whole thing (although shepherding it through our CI systems can take a bit of attention). Understanding the change and being able to work out if it really is the right thing takes the most time.
I've been toying with the idea of setting up an "offices hours" where people can sign up for time with someone here at Puppet Labs. Then talk on IRC or Skype about the change and work out together what needs to be done. On Jul 23, 2012, at 11:44 PM, David Schmitt wrote: > On 23.07.2012 18:21, Andrew Parker wrote: >> Yeah, there is a problem with getting pull requests reviewed. And I >> think you are right, the problem stems from being short staffed for >> responding to these things. A pull request can take considerable >> amount of time to review and shepherd through (or it can take very >> little time if it is good, clean, tested code that is fixing an >> obvious problem). > > Is there anything that can be done to accelerate the manual part of this? > Like running the tests for each pull-request or something? > > > > Best Regards, David > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/puppet-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
