On Fri, May 3, 2013 at 11:05 AM, Andy Parker <[email protected]> wrote: > On Thu, May 2, 2013 at 6:59 PM, Dustin J. Mitchell <[email protected]> > wrote: >> >> The way 'diff' is hardcoded into the source is a little janky. It'd >> be nice to allow that to be fully customized, rather than just >> accepting args to add to a hard-coded 'diff'. >> > > I do, however, agree with Dustin. The first time I found the diff call it > was a bit of a WTF moment. I would be for either making the entire diff call > configurable or replace the call to an external prog with a ruby diff > implementation. > > If we change the call (such as dropping -u in certain cases) could this > cause any problems? Are there any systems that are using that diff output > for anything? Or is this just a thing that humans read?
They are only for human consumption. Dropping the `-u` where supported, though, is a huge loss for humans - the classic "ed" diffs are not exactly friendly to read. -- Daniel Pittman ⎋ Puppet Labs Developer – http://puppetlabs.com ♲ Made with 100 percent post-consumer electrons -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
