On Wednesday, May 15, 2013 4:54:33 AM UTC+10, Andy Parker wrote: > > It looks like the PE team hit this problem for AIX and created a fix > where they change the default diff_args based on the platform: > https://github.com/puppetlabs/puppet/pull/1637 > > So it looks like puppet is going to try and be smart by default. >
I have two objections to that solution. Firstly, AIX5.3 isn't the only operating system not supporting diff -u - it's a problem on all HP-UX, as well as on some legacy Solaris. Secondly, if diff -u isn't available it may make sense to try diff -c instead. The output from that is I think more readable. If we were making Puppet smarter, perhaps the thing to do is make an additional call to 'diff' to see if it supports the default args - if it doesn't it will return exit code 2. I suppose I could submit a patch that does this if the solution sounds good. That said, I think being able to configure the diff_args in puppet.conf is also an adequate solution. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
