On Tue, May 14, 2013 at 9:30 PM, Alex Harvey <[email protected]> wrote: > > > On Wednesday, May 15, 2013 4:54:33 AM UTC+10, Andy Parker wrote: >> >> It looks like the PE team hit this problem for AIX and created a fix >> where they change the default diff_args based on the platform: >> https://github.com/puppetlabs/puppet/pull/1637 >> >> So it looks like puppet is going to try and be smart by default. > > > I have two objections to that solution. > > Firstly, AIX5.3 isn't the only operating system not supporting diff -u - > it's a problem on all HP-UX, as well as on some legacy Solaris. >
Right, I hadn't noticed at first that AIX was not part of the original report. I had read the issue after it had been updated to say AIX and had missed the HP-UX part. > Secondly, if diff -u isn't available it may make sense to try diff -c > instead. The output from that is I think more readable. > > If we were making Puppet smarter, perhaps the thing to do is make an > additional call to 'diff' to see if it supports the default args - if it > doesn't it will return exit code 2. > My problem with all of these solutions is that they all increase the startup time for everything. The one that was submitted calls facter on startup, and your solution would execute diff (and presents other issues related to getting what the diff program is since that is configurable). That doesn't seem ideal, and granted, it also isn't ideal that puppet can't run with the default settings on some platforms. > I suppose I could submit a patch that does this if the solution sounds good. > That said, I think being able to configure the diff_args in puppet.conf is > also an adequate solution. > I would be interested in seeing the proposal, but I almost get the sense that the installation process should really just be laying down the right default puppet.conf. > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/puppet-dev?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > -- Andrew Parker [email protected] Freenode: zaphod42 Twitter: @aparker42 Software Developer Join us at PuppetConf 2013, August 22-23 in San Francisco - http://bit.ly/pupconf13 Register now and take advantage of the Early Bird discount - save 25%! -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/puppet-dev?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
