On Fri, Apr 8, 2011 at 10:13 AM, Benjamin Severs <[email protected]>wrote:
> > > Michael, > > > > > > I've done some more testing and have verified that the fix for the > memory > > > leak > > > is indeed in the patches you labeled as "PJMP related fixes associated > > > with leaks". The problem we have is that those patches are on top of > > > new features > > > (mirroring?) not included in the 2.8.2 release, and we are not prepared > > > to take those features yet. > > > > > > Is it possible to provide a patch that implements the same fix > introduced > > > in > > > those patches based off of the 2.8.2 release? > > > > Sure, we can work on a backport to 2.8.2. Which of the changes in the > PJMP > > sets resolved the issue? Was it the addition of the src/server/ > > pjmp-machines.sm (and changes in getattr to use that) or were other > changes > > included too? Did the src/proto/PINT-le-bytefield.c changes (from the > 3rd > > set of items) make any difference? > > > > Thanks, > > Michael > > > > I believe the changes were in the addition of the pjmp-machines.sm and the > getattr changes. I tried the src/proto/PINT-le-bytefield.c changes and > they > didn't make any noticable difference. > > I basically checked out the cvs Orange-Branch branch and started at a past > commit that was made around the time of the 2.8.2 release. I verified that > the > memory leak existed in that commit. I then worked forward through the > commit > history until the leak was fixed. It wasn't fixed until those pjmp commits > went > in. So, I can't say that the addition of the pjmp-machines.sm fixed it, > but > that commit did. > > -- > Benjamin Severs > Great, that's what I needed to know. See the attached patch, after a couple thousand pvfs2-ls commands on a smallish directory I didn't see any increase in memory usage for the pvfs2-server process. The patch just includes the re-work Becky did of the pjmp state machine as it applies to the list-attr state machine and should apply cleaning to the 2.8.2 release. Let me know how it looks in your testing. Thanks, Michael > _______________________________________________ > Pvfs2-developers mailing list > [email protected] > http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers >
pjmp.patch
Description: Binary data
_______________________________________________ Pvfs2-developers mailing list [email protected] http://www.beowulf-underground.org/mailman/listinfo/pvfs2-developers
