On 03/06/14 22:16, "Juan J. Martínez" wrote:
On 03/06/14 22:01, Adam Bark wrote:
[...]
How about having it as a subrepository?
http://mercurial.selenic.com/wiki/Subrepository
If this sounds acceptable I'll take a crack at it and get pyglet.image
to import it.
Out pypng "fork" has local patches. We had a ticket with some fixes for
stuff that was never fixed upstream. I think it might not be just get
the code and that's it as it may break things eventually because
upstream changes. So at the end having a subrepository is not that
different of it being an external dependency, is it?
That's a pity. The subrepository makes releases with the code much
simpler. We could have the subrepository point to our own fork.
As I see it either we keep going with a fork (thus integrating the code
so it is stable and works for us), or we get rid of it and add it as an
optional dependency that the user can install by his own means.
My two cents ;)
Regards,
Juan
I think what it comes down to is whether pypng should just be part of
pyglet or a separate project like avbin. If it should be separate then
we should perhaps set up a fork of pypng with our fixes. I think this
should make integration of upstream patches simpler as well as pushing
our patches upstream.
Thoughts?
Adam.
--
You received this message because you are subscribed to the Google Groups
"pyglet-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/pyglet-users.
For more options, visit https://groups.google.com/d/optout.
