Great. I went ahead and manually commited it. It's a bit of a change from the previous implementation, but it's a nice upgrade and fundamentally solid. Now that it's in, we can see if anyone finds any edge cases. I've been using it in a few test projects already, without issues (other than the ones you fixed already :))
Thanks Leif On Tuesday, April 4, 2017 at 10:43:05 PM UTC+9, Leif Theden wrote: > > I ran through the test suite again (passed) and can't think of any other > tests for it ATM. I don't see a problem merging it. > > On Monday, April 3, 2017 at 10:27:45 AM UTC-5, Benjamin Moran wrote: >> >> Thanks Leif. It would be great to get this bit of code into the next >> release. If you see anything that you've missed, I'm available to help if >> necessary. >> >> >> >> On Monday, April 3, 2017 at 9:15:27 PM UTC+9, Leif Theden wrote: >>> >>> No worries Benjamin. Let me look over it today and think about >>> compatibility. I think I covered all of the major functionality when I >>> wrote it, but that was over a year ago. I'll let you know this week. >>> On Mon, Apr 3, 2017 at 7:12 AM Benjamin Moran <[email protected]> >>> wrote: >>> >>>> Hi Leif, >>>> >>>> Sorry to pester, but do you have any issues with merging this in? I can >>>> do it of you're short on time. >>>> >>>> -- >>>> You received this message because you are subscribed to a topic in the >>>> Google Groups "pyglet-users" group. >>>> To unsubscribe from this topic, visit >>>> https://groups.google.com/d/topic/pyglet-users/_0eLxtKfUy4/unsubscribe. >>>> To unsubscribe from this group and all its topics, send an email to >>>> [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at https://groups.google.com/group/pyglet-users. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
