Hi all,
see my most recent post on code review tools here:
http://ivory.idyll.org/blog/dec-08/code-review-and-git-replies.html
I got some useful links in replies to my earlier post, and they're
summarized there.
I don't have much experience with code review tools, so I'm not positive
about this. However, it seems like the code review tools mostly
focus on *patch* review rather than review of already existing code
(which is what we want to do for pygr). So while I think we should look
into using one or another code review tool (or even just e-mail) for
every new patch, I don't know how well they fit existing code review.
So instead I'd like to propose the following process for our first code
review.
- choose an initial reviewer & a simple module that someone other than
Chris is moderately familiar with (I propose me, and seqdb.py).
- have that reviewer do a linear pass through the code, noting:
+ code blocks that are completely untested (by coverage analysis
on automated tests)
+ places where reformatting and/or comments could help with
reading and understanding the code at some shallow level
+ anything else that catches their eye
- make a "patch set" containing the reviewer notes available via git,
and have everybody else (esp Chris Lee) make a sweep through the
code, adding/answering/extending to the initial reviewer notes where
they want.
- get together on IRC or Skype Chat (!not audio!) at a designated time
and work through the comments and issues together. A code snippet
service may work well as a way to share code here.
- have primary reviewer integrate all of the suggested changes into a
single "clean" patchset.
- post for review & integration into the main code base.
I think this is a good way to do a fairly quick, lightweight, and
shallow code review; it may not get at all the issues, but it fits the
way I tend to work and it will expose everyone who participates to the
code at a deeper level than a single reading.
What do people think?
cheers,
--titus
--
C. Titus Brown, [email protected]
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"pygr-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
