On Mon, Dec 29, 2008 at 06:06:21AM -0800, Istvan Albert wrote: -> On Dec 24, 2:01?pm, "C. Titus Brown" <[email protected]> wrote: -> -> > about this. However, it seems like the code review tools mostly -> > focus on *patch* review rather than review of already existing code -> > (which is what we want to do for pygr). ?So while I think we should look -> > into using one or another code review tool (or even just e-mail) for -> > every new patch, I don't know how well they fit existing code review. -> -> One suggestion: how about using the google code repository for this. -> One could import the whole pygr into svn, branch it off, and hack -> away. That way there is versioning via svn and you get a code review -> tool as well. Once the changes are accepted they'll be transferred to -> the main git repository.
Hi Istvan, I'm trying to think of what problems this solves :). Is it that we could use Rietveld? This doesn't solve the patch vs existing code review issues, although I suppose we could frame existing code reviews as patch requests...? cheers, --titus -- C. Titus Brown, [email protected] --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "pygr-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/pygr-dev?hl=en -~----------~----~----~----~------~----~------~--~---
