Hi all,
I finished my code review & changes to Istvan's new test branch here,
http://github.com/ctb/pygr-psu/tree/master
and then hand-merged the 'tests/' directory into the latest HEAD. The
results are here:
http://github.com/ctb/pygr/tree/psu-tests-branch
I ran into two big-ish problems:
- first, Istvan didn't isolate his changes to the tests/ directory, and
I couldn't figure out how to do an automatic merge of just that
subdir. Hence the manual merge.
In particular, this means that the doctests (which don't exist in the
official repo) had to be commented out.
- second, Chris recently added some new code under tests/ that couldn't
be automatically merged into Istvan's code, so I had to manually
merge that, too.
There are still one or two things that don't work but I am going to
leave them to someone else to fix! Someone should also be sure to test
this on Windows; I don't think I introduced any OS-specific problems but
I don't have easy access to a Windows box to check.
Once the remaining problems are fixed, I definitely recommend that
Isvan's test branch gets merged into the main repo; it's a pretty big
simplification of the test framework and it's now been gone over by
two pairs of eyes, so it should be reasonable sane.
Also, Istvan, I made one or two potentially controversial changes to
your test code, mostly in test running and temporary directory
creation/removal. It might be worth going over the commit logs of the
pygr-psu repository to see how much you disagree with them ;)
cheers,
--titus
--
C. Titus Brown, [email protected]
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"pygr-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/pygr-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
